Skip to content

Clarify dirty finished agents need cleanup#430

Merged
NagyVikt merged 1 commit intomainfrom
agent/codex/clarify-finished-active-agents-cleanup-s-2026-04-25-16-06
Apr 25, 2026
Merged

Clarify dirty finished agents need cleanup#430
NagyVikt merged 1 commit intomainfrom
agent/codex/clarify-finished-active-agents-cleanup-s-2026-04-25-16-06

Conversation

@NagyVikt
Copy link
Copy Markdown
Collaborator

Automated by gx branch finish (PR flow).

Finished Active Agents rows were truthful but ambiguous: users read them as complete even when a dirty worktree still needed cleanup. Keep the underlying activityKind stable, but present that state as Needs cleanup in the sidebar, summaries, tooltips, and session descriptions. Split these rows out of Idle / thinking so the remaining worktree has an obvious cleanup reason.

Constraint: activityKind remains finished for compatibility with existing state derivation

Constraint: Active Agents template must stay byte-for-byte synced with the canonical extension source

Rejected: Hide finished dirty worktrees | hiding would make leftover files less visible and harder to clean

Confidence: high

Scope-risk: narrow

Directive: Do not reintroduce Finished as user-facing wording for dirty idle worktrees without explaining cleanup state

Tested: node --test test/vscode-active-agents-session-state.test.js test/metadata.test.js

Tested: node --check vscode/guardex-active-agents/extension.js

Tested: openspec validate --specs
@NagyVikt NagyVikt merged commit 3945192 into main Apr 25, 2026
@NagyVikt NagyVikt deleted the agent/codex/clarify-finished-active-agents-cleanup-s-2026-04-25-16-06 branch April 25, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant